RJS-2204: Re-enabled client reset tests #6738
Conversation
kraenhansen
force-pushed
the
kh/client-reset-tests
branch
from
c2e3589
to
be9451e
Compare
| throw new Error(`Cannot trigger client reset in ${maxAttempts} attempts`); | ||
| await baasAdminClient.ensureLogIn(); | ||
| const { _id } = await baasAdminClient.getAppByClientAppId(app.id); | ||
| syncSession.pause(); |
There was a problem hiding this comment.
Do we need a connection listener to ensure it is safe to call forceSyncReset()?
There was a problem hiding this comment.
Safe in what way? That we have access to BaaS from the test suite or perhaps that the Realm is ready to get the reset? (for the latter we are doing a await syncSession.uploadAllLocalChanges() before calling triggerClientReset).
There was a problem hiding this comment.
pause() will not immediately pause the connection, and I wonder if we need to wait for it before calling forceSyncReset()?
There was a problem hiding this comment.
Ah 🤔 I honestly don't know .. I think it's safe to assume resume will internally block for anything async that pause started on the sync client thread. (I just copied this from the C++ SDK's test).
kraenhansen
force-pushed
the
kh/client-reset-tests
branch
from
be9451e
to
90ae540
Compare
What, How & Why?
Fixes #5500 by calling the admin API to perform client reset.
This also brings a refactor of the app importer to take the client as an argument, since we want to instantiate and call this outside of the context of importing apps.
Note: This should be rebased once #6733 merge.