Refactored Node test environments to share more #6798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/node-test-env-refactored
branch
from
cbb3e02
to
b0f3dd7
Compare
kraenhansen
commented
Jul 19, 2024
Comment on lines
-21
to
-35
| const fs = require("fs-extra"); | ||
| const path = require("path"); | ||
| const v8 = require("v8"); | ||
| const vm = require("vm"); | ||
|
|
||
| v8.setFlagsFromString("--expose_gc"); | ||
|
|
||
| const client = new Client({ | ||
| title: `Node.js v${process.versions.node} on ${os.platform()} (via CommonJS)`, | ||
| tests(context) { | ||
| // Exposing the Realm constructor as a global | ||
| global.fs = fs; | ||
| global.path = path; | ||
| global.environment = { ...context, node: true }; | ||
| global.gc = vm.runInNewContext("gc"); |
There was a problem hiding this comment.
The main idea behind this refactor is to move this into a shared "node/src/setup-globals.ts" used across these two "runners" and the test ran with bare mocha (without mocha-remote - used when debugging native code).
kraenhansen
commented
Jul 19, 2024
| @@ -16,7 +16,14 @@ | |||
| // | |||
| //////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| // NOTE: This file is only supposed to be imported from a Node.js environment | |||
| if (typeof process.versions.node !== "string") { | |||
| throw new Error("This file is only supposed to be imported from a Node.js environment!"); | |||
There was a problem hiding this comment.
Asserting that this gets imported from node instead of simply commenting the intent.
kraenhansen
commented
Jul 19, 2024
Comment on lines
+58
to
+60
| if (typeof title === "string" && this.parent?.root) { | ||
| this.parent.title = title; | ||
| } |
There was a problem hiding this comment.
This was needed to get the title from "inject-dev-environment.ts" to propagate as expected.
kraenhansen
added
no-changelog
no-jira-ticket
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This is a refactor of the node test environment + the node-based dev environment (running tests without mocha-remote).