Fix some packaging problems #8338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/packaging-fixes
branch
6 times, most recently
from
a56a9cb
to
a017be7
Compare
tgoyne
force-pushed
the
tg/packaging-fixes
branch
from
e08384a
to
1ee9d5a
Compare
tgoyne
force-pushed
the
tg/packaging-fixes
branch
from
1ee9d5a
to
133a449
Compare
leemaguire
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthage downloads a semi-random zip with xcframework in the name, so the SPM binaries need to not have that in the name.
The app store rejects things built with beta SDKs, so the obj-c framework needs to be built with Xcode 14 and only use Xcode 15 for the visionOS slices. I found this really obnoxious to write in shell, so I ported it to ruby, and pulled all the packaging logic from github_release.rb over to that so that it's testable without publishing releases.
Fixes #8326. Fixes #8339.