Allow creating notifiers inside write transactions before the first change #8439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2023
|
Thank you, makes sense. I hope this can be prioritized as a "hotfix" without waiting on a major release. |
tgoyne
force-pushed
the
tg/write-transaction-notification
branch
from
407d57b
to
a382ae5
Compare
tgoyne
force-pushed
the
tg/write-transaction-notification
branch
from
a382ae5
to
bdd98d3
Compare
…hange Core has allowed this for a while, but we had our own validation which made it not work.
tgoyne
force-pushed
the
tg/write-transaction-notification
branch
from
bdd98d3
to
535097a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core has allowed this for a while (and we claimed to allow it as of 10.39.1), but we had our own validation which made it not work.