Enable customizing date and data property encoding #8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaafanador3
approved these changes
Jan 9, 2024
We were unintentionally bypassing the encoder when converting properties to strings, which broke things like JSONEncoder.dateEncodingStrategy.
tgoyne
force-pushed
the
tg/date-codeable
branch
from
8192624
to
5b2f4bd
Compare
dianaafanador3
pushed a commit
that referenced
this pull request
Jan 18, 2024
We were unintentionally bypassing the encoder when converting properties to strings, which broke things like JSONEncoder.dateEncodingStrategy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unintentionally bypassing the encoder when converting properties to strings, which broke things like JSONEncoder.dateEncodingStrategy.
I also added tests for some other Codable things which we weren't testing, such as nested objects and
keyEncodingStrategy. Usingencoder.outputFormatting = [.sortedKeys]makes the resulting json consistent between platforms, which lets us check that we got exactly the input string after round-tripping through a Realm object.Fixes #8425.