Fix some bugs with the new release pipeline #8488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions/upload-artifact follows symlinks when asked to archive a directory, which results in the release package having three copies of each macos/catalyst library. To fix this, skip extracting the zip before archiving even though it results in an awkward nested zip.
| test-installation: | ||
| runs-on: macos-13 | ||
| name: Run installation test for ${{ matrix.platform }}, ${{ matrix.installation }} and ${{ matrix.linkage }} | ||
| needs: [create-release, prepare] | ||
| needs: [create-release, prepare, publish-cocoapods] |
There was a problem hiding this comment.
my mistake not having in mind that we need CocoaPods published for the installation tests
| VERSION="$(sed -n 's/^VERSION=\(.*\)$/\1/p' "${source_root}/dependencies.list")" | ||
| PRERELEASE_REGEX='alpha|beta|rc|preview' | ||
| if [[ $VERSION =~ $PRERELEASE_REGEX ]]; then | ||
| echo "Pre-release version" | ||
| exit 0 | ||
| fi | ||
|
|
||
| s3cmd put --recursive --acl-public --access_key=${AWS_ACCESS_KEY_ID} --secret_key=${AWS_SECRET_ACCESS_KEY} docs/swift_output/ s3://realm-sdks/docs/realm-sdks/swift/${VERSION}/ | ||
| s3cmd put --recursive --acl-public --access_key=${AWS_ACCESS_KEY_ID} --secret_key=${AWS_SECRET_ACCESS_KEY} docs/swift_output/ s3://realm-sdks/docs/realm-sdks/swift/latest/ | ||
| s3cmd put --no-mime-magic --guess-mime-type --recursive --acl-public docs/swift_output/ s3://realm-sdks/docs/realm-sdks/swift/${VERSION}/ |
There was a problem hiding this comment.
are we getting the credentials from the environment values here?
There was a problem hiding this comment.
Yeah, s3cmd reads the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables if they exist.
dianaafanador3
approved these changes
Feb 14, 2024
|
Successful run with the new tokens: https://github.com/realm/realm-swift/actions/runs/7904978638/job/21576536648 |
tgoyne
force-pushed
the
tg/release-symlink
branch
from
3bf3f92
to
1679fd1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/upload-artifact follows symlinks when asked to archive a directory, which results in the release package having three copies of each macos/catalyst library. To fix this, skip extracting the zip before archiving even though it results in an awkward nested zip.
Building RealmSwift also builds Realm, so we don't need the obj-c specific build jobs.
Docs and update checker publishing were failing due to s3cmd not being installed. Docs publishing still doesn't work because the s3 account we're using doesn't have access to the bucket. Passing the token as a CLI argument hits a bug in s3cmd where access denied errors are reported as the config file being malformed, while passing them as env variables gives more accurate errors.
Using setup-ruby plus bundler to install ruby and gems makes it only take 5-10 seconds and lets us pin specific versions of the gems.