Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to core 14.9.0 #8597

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Upgrade to core 14.9.0 #8597

merged 4 commits into from
Jun 6, 2024

Conversation

dianaafanador3
Copy link
Contributor

@dianaafanador3 dianaafanador3 commented May 20, 2024

Upgrade to core 14.9.0

CHANGELOG.md Outdated
([Core #7670](https://github.com/realm/realm-core/issues/7670), since v14.6.0).
* Inserting the same link to the same key in a dictionary more than once would incorrectly
create multiple backlinks to the object. This did not appear to cause any crashes later, but would
have affecting explicit backlink count queries (eg: `$0.links.count`) and possibly notifications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We either don't support this query at all or it has a different syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is referring to queries on backlinks for example $0.linkingObjects.count == 3 where

class TestObject: Object {
    @Persisted var objectCol: TestObject?

    @Persisted(originProperty: "objectCol")
    var linkingObjects: LinkingObjects< TestObject >
}

And the return count will be wrong because it will create multiple backlinks instead of just one.
Correct me if I'm wrong @tgoyne

CHANGELOG.md Outdated Show resolved Hide resolved
@tgoyne
Copy link
Member

tgoyne commented May 21, 2024

I don't think we can merge this separately from #8546 because this includes the protocol version bump which indicates that we're collections-in-mixed aware.

@dianaafanador3 dianaafanador3 changed the title Upgrade to core 14.7.0 Upgrade to core 14.8.0 May 28, 2024
@dianaafanador3 dianaafanador3 force-pushed the dp/update-core-14.7.0 branch 4 times, most recently from f36ed09 to 79e437e Compare May 29, 2024 10:20
@dianaafanador3 dianaafanador3 changed the title Upgrade to core 14.8.0 Upgrade to core 14.9.0 Jun 3, 2024
@dianaafanador3 dianaafanador3 force-pushed the dp/update-core-14.7.0 branch 2 times, most recently from f2e21bf to b9a8602 Compare June 4, 2024 09:03
@dianaafanador3 dianaafanador3 merged commit a9efda1 into master Jun 6, 2024
320 of 326 checks passed
@dianaafanador3 dianaafanador3 deleted the dp/update-core-14.7.0 branch June 6, 2024 15:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants