Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCOCOA-1883: Add "Sync is not enabled for this App" as a catchable error in error handler #8643

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

dianaafanador3
Copy link
Contributor

@dianaafanador3 dianaafanador3 commented Jul 2, 2024

Report any sync errors tagged with warning action from the server via the sync error handler.

@cla-bot cla-bot bot added the cla: yes label Jul 2, 2024
@dianaafanador3 dianaafanador3 marked this pull request as ready for review July 2, 2024 14:55
Realm/ObjectServerTests/SwiftFlexibleSyncServerTests.swift Outdated Show resolved Hide resolved
Realm/ObjectServerTests/SwiftFlexibleSyncServerTests.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything meaningful to contribute but the tests indicate that the error is reported to the error handler

@dianaafanador3
Copy link
Contributor Author

Solved PR comments @tgoyne

Realm/RLMError.h Outdated
Comment on lines 332 to 333
An error indicating the server send down an error with a warning action, which
needs to be executed by the client or the end user.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings don't have an action which needs to be executed by the client or end user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgoyne Reworded, let me know if this fits

@dianaafanador3 dianaafanador3 force-pushed the dp/expose-sync-not-enable-error branch 2 times, most recently from c573de8 to b3ece49 Compare July 24, 2024 14:26
@dianaafanador3 dianaafanador3 force-pushed the dp/expose-sync-not-enable-error branch from b3ece49 to 6191b22 Compare July 24, 2024 14:27
@dianaafanador3 dianaafanador3 merged commit baaa5a1 into master Jul 24, 2024
123 of 133 checks passed
@dianaafanador3 dianaafanador3 deleted the dp/expose-sync-not-enable-error branch July 24, 2024 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Sync is not enabled for this App" as a catchable error in error handler
3 participants