fix: internal error on pin/unpin (usememos#4332)

realreus319 · Jan 31, 2025 · 7ed3a12 · 7ed3a12
1 parent 5ec3150
commit 7ed3a12
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/store/db/mysql/memo.go b/store/db/mysql/memo.go
@@ -242,6 +242,9 @@ func (d *DB) UpdateMemo(ctx context.Context, update *store.UpdateMemo) error {
 		}
 		set, args = append(set, "`payload` = ?"), append(args, string(payloadBytes))
 	}
+	if len(args) == 0 {
+		return nil
+	}
 	args = append(args, update.ID)
 
 	stmt := "UPDATE `memo` SET " + strings.Join(set, ", ") + " WHERE `id` = ?"

diff --git a/store/db/postgres/memo.go b/store/db/postgres/memo.go
@@ -233,6 +233,9 @@ func (d *DB) UpdateMemo(ctx context.Context, update *store.UpdateMemo) error {
 		}
 		set, args = append(set, "payload = "+placeholder(len(args)+1)), append(args, string(payloadBytes))
 	}
+	if len(args) == 0 {
+		return nil
+	}
 
 	stmt := `UPDATE memo SET ` + strings.Join(set, ", ") + ` WHERE id = ` + placeholder(len(args)+1)
 	args = append(args, update.ID)

diff --git a/store/db/sqlite/memo.go b/store/db/sqlite/memo.go
@@ -220,6 +220,9 @@ func (d *DB) UpdateMemo(ctx context.Context, update *store.UpdateMemo) error {
 		}
 		set, args = append(set, "`payload` = ?"), append(args, string(payloadBytes))
 	}
+	if len(args) == 0 {
+		return nil
+	}
 	args = append(args, update.ID)
 
 	stmt := "UPDATE `memo` SET " + strings.Join(set, ", ") + " WHERE `id` = ?"