Skip to content

Commit

Permalink
fix(screens): Fix title bar height in thread on desktop platforms
Browse files Browse the repository at this point in the history
  • Loading branch information
realth000 committed Dec 16, 2023
1 parent 305b4d9 commit 7c21f29
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions lib/screens/thread/post_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import 'package:tsdm_client/providers/net_client_provider.dart';
import 'package:tsdm_client/providers/screen_state_provider.dart';
import 'package:tsdm_client/routes/screen_paths.dart';
import 'package:tsdm_client/utils/debug.dart';
import 'package:tsdm_client/utils/platform.dart';
import 'package:tsdm_client/utils/show_toast.dart';
import 'package:tsdm_client/widgets/list_app_bar.dart';
import 'package:universal_html/html.dart' as uh;
Expand All @@ -26,6 +27,9 @@ import 'package:url_launcher/url_launcher.dart';
const _headerMaxExtent = 100.0;
const _headerMinExtent = 100.0;

const _headerMaxExtentDesktop = 60.0;
const _headerMinExtentDesktop = 60.0;

// enum _MenuActions {
// refresh,
// copyUrl,
Expand Down Expand Up @@ -325,7 +329,12 @@ class _PostListState<T> extends ConsumerState<PostList<T>> {
double shrinkOffset,
) {
String? titleText;
final isExpandHeader = _listScrollController.offset < _headerMaxExtent;
var isExpandHeader = false;
if (isDesktop) {
isExpandHeader = _listScrollController.offset < _headerMaxExtentDesktop;
} else {
isExpandHeader = _listScrollController.offset < _headerMaxExtent;
}

if (widget.title != null && !isExpandHeader) {
titleText = widget.title;
Expand Down Expand Up @@ -464,10 +473,12 @@ class SliverAppBarPersistentDelegate extends SliverPersistentHeaderDelegate {
}

@override
double get maxExtent => _headerMaxExtent;
double get maxExtent =>
isDesktop ? _headerMaxExtentDesktop : _headerMaxExtent;

@override
double get minExtent => _headerMinExtent;
double get minExtent =>
isDesktop ? _headerMinExtentDesktop : _headerMinExtent;

@override
bool shouldRebuild(covariant SliverPersistentHeaderDelegate oldDelegate) =>
Expand Down

0 comments on commit 7c21f29

Please sign in to comment.