Gui: remove duplicated PropertyModel signal of dataChanged()

realthunder · Jun 8, 2020 · 42cb7bb · 42cb7bb
1 parent 036f6ad
commit 42cb7bb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Gui/propertyeditor/PropertyModel.cpp b/src/Gui/propertyeditor/PropertyModel.cpp
@@ -354,7 +354,12 @@ void PropertyModel::buildUp(const PropertyModel::PropertyList& props)
         auto flushChanges = [&]() {
             if (beginChange < 0)
                 return;
-            dataChanged(this->index(beginChange,0,midx), this->index(endChange,1,midx));
+            (void)endChange;
+            // There is no need to signal dataChange(), because PropertyEditor
+            // will call PropertyModel::updateProperty() on any property
+            // changes.
+            //
+            // dataChanged(this->index(beginChange,0,midx), this->index(endChange,1,midx));
             beginChange = -1;
         };