-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat core/parser: add silent mode to skip not supported statements #509
Conversation
del `.lower()` from __str__ (table names into quotes is case-sensitive)
# Conflicts: # sqllineage/core/models.py
Is the silent_mode option also required for the command line? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 40 40
Lines 2052 2056 +4
=======================================
+ Hits 2040 2044 +4
Misses 12 12 ☔ View full report in Codecov by Sentry. |
Optional, default is False |
# Conflicts: # sqllineage/cli.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this silent_mode idea very much. Can you also change the signature of abstract class LineageAnalyzer.analyze to be consistent? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add silent mode into analizer because it has to be deleted with regular expressions
Closes #513