Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat core/parser: add silent mode to skip not supported statements #509

Merged
merged 12 commits into from
Dec 25, 2023

Conversation

kkozhakin
Copy link
Contributor

@kkozhakin kkozhakin commented Dec 20, 2023

Add silent mode into analizer because it has to be deleted with regular expressions


Closes #513

@maoxingda
Copy link
Contributor

Is the silent_mode option also required for the command line?

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0cf6aa) 99.41% compared to head (9ea8f50) 99.41%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          40       40           
  Lines        2052     2056    +4     
=======================================
+ Hits         2040     2044    +4     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkozhakin
Copy link
Contributor Author

kkozhakin commented Dec 20, 2023

Is the silent_mode option also required for the command line?

Optional, default is False
For me console mode is not required but I add this option

Copy link
Owner

@reata reata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this silent_mode idea very much. Can you also change the signature of abstract class LineageAnalyzer.analyze to be consistent? Thanks

Copy link
Owner

@reata reata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reata reata merged commit 4ac7fde into reata:master Dec 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent Mode Option to Suppress UnsupportedStatementException
3 participants