Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent lineage results #661

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

rubytobi
Copy link
Contributor

Closes #652

  • When resolving wildcards, we collect columns in a set which isn't guaranteed to be consistently order between executions
  • When returning column lineage, we only sort by first and last element which leaves space for variation when more elements are in the lineage

@rubytobi rubytobi marked this pull request as ready for review November 15, 2024 11:27
@rubytobi rubytobi changed the title Fix consistency fix: consistent lineage results Nov 15, 2024
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (b5b5e10) to head (ed6ce89).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          41       41           
  Lines        2229     2237    +8     
=======================================
+ Hits         2219     2227    +8     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reata reata merged commit 10442e5 into reata:master Feb 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent order of lineage tuples
2 participants