Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make Copy/Paste keyboard shortcuts working with useSelection #302

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Edouard-Tby
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

The aim of this PR is to fix issue #272 => Copy/Paste/Refresh keyboard shortcuts not working if using useSelection Hook

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #272

What is the new behavior?

Copy paste is now working (you can try it for instance on the text 'Hold Cammand/CTRL ....') in the Modifier Key section.

image

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 56a509d
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/677bbaaa13d7960008fad3d3
😎 Deploy Preview https://deploy-preview-302--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Edouard-Tby Edouard-Tby requested a review from amcdnl January 6, 2025 11:15
@amcdnl amcdnl merged commit ebcff08 into reaviz:master Jan 13, 2025
5 checks passed
@Edouard-Tby Edouard-Tby deleted the fix-copy-paste-shortcuts branch January 13, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants