Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnit10] Replace deleted PHPUnit methods #438

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

66Ton99
Copy link
Contributor

@66Ton99 66Ton99 commented Jan 15, 2025

Replace deleted PHPUnit methods:
assertClassHasStaticAttribute
classHasStaticAttribute
assertClassNotHasStaticAttribute

by property_exists()

sebastianbergmann/phpunit#4601

@66Ton99 66Ton99 force-pushed the phpunit10-removed-assersions branch from c1e929f to 39d6ddc Compare January 15, 2025 00:51
@66Ton99 66Ton99 changed the title [PHPUnit] Replace deleted PHPUnit methods [PHPUnit10] Replace deleted PHPUnit methods Jan 15, 2025
@samsonasik
Copy link
Member

Please run:

vendor/bin/rector && composer fix-cs

to fix CI

@66Ton99 66Ton99 force-pushed the phpunit10-removed-assersions branch 3 times, most recently from 5fa7dbf to be4f218 Compare January 15, 2025 10:45
@66Ton99 66Ton99 force-pushed the phpunit10-removed-assersions branch from be4f218 to bb77782 Compare January 15, 2025 10:50
…ibute, classHasStaticAttribute and assertClassNotHasStaticAttribute by property_exists()

sebastianbergmann/phpunit#4601
@66Ton99 66Ton99 force-pushed the phpunit10-removed-assersions branch from bb77782 to 4ed85c1 Compare January 15, 2025 16:33
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try

@samsonasik samsonasik merged commit 3984732 into rectorphp:main Jan 17, 2025
6 checks passed
@samsonasik
Copy link
Member

Thank you @66Ton99

@samsonasik
Copy link
Member

@66Ton99 next, could you register to phpunit100 config ?

https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/phpunit100.php

thank you.

@samsonasik
Copy link
Member

@66Ton99 nvm, I registered at new PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants