-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHPUnit10] Replace deleted PHPUnit methods #438
Merged
samsonasik
merged 1 commit into
rectorphp:main
from
66Ton99:phpunit10-removed-assersions
Jan 17, 2025
Merged
[PHPUnit10] Replace deleted PHPUnit methods #438
samsonasik
merged 1 commit into
rectorphp:main
from
66Ton99:phpunit10-removed-assersions
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66Ton99
force-pushed
the
phpunit10-removed-assersions
branch
from
January 15, 2025 00:51
c1e929f
to
39d6ddc
Compare
66Ton99
changed the title
[PHPUnit] Replace deleted PHPUnit methods
[PHPUnit10] Replace deleted PHPUnit methods
Jan 15, 2025
Please run:
to fix CI |
66Ton99
force-pushed
the
phpunit10-removed-assersions
branch
3 times, most recently
from
January 15, 2025 10:45
5fa7dbf
to
be4f218
Compare
samsonasik
reviewed
Jan 15, 2025
rules/PHPUnit100/Rector/MethodCall/PropertyExistsWithoutAssertRector.php
Show resolved
Hide resolved
66Ton99
force-pushed
the
phpunit10-removed-assersions
branch
from
January 15, 2025 10:50
be4f218
to
bb77782
Compare
samsonasik
reviewed
Jan 15, 2025
rules/PHPUnit100/Rector/MethodCall/PropertyExistsWithoutAssertRector.php
Outdated
Show resolved
Hide resolved
…ibute, classHasStaticAttribute and assertClassNotHasStaticAttribute by property_exists() sebastianbergmann/phpunit#4601
66Ton99
force-pushed
the
phpunit10-removed-assersions
branch
from
January 15, 2025 16:33
bb77782
to
4ed85c1
Compare
samsonasik
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try
Thank you @66Ton99 |
@66Ton99 next, could you register to phpunit100 config ? https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/phpunit100.php thank you. |
@66Ton99 nvm, I registered at new PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deleted PHPUnit methods:
assertClassHasStaticAttribute
classHasStaticAttribute
assertClassNotHasStaticAttribute
by property_exists()
sebastianbergmann/phpunit#4601