refactor: Extract assert package from existing tests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the third copy-paste of assertEqual, I think it's time to make an internal test assertion library. This is similar to [testify]'s assert package, mostly because it's the one I'm most familiar with. This now uses [go-cmp] instead of `reflect.DeepEqual` for comparing values. We get free diff reports out of it too! I added the package to a new `internal` directory to make it clear that this isn't part of the application itself. It also prevents it from being imported from anywhere else, even though there's no reason to import from this module anyway. [go-cmp]: https://github.com/google/go-cmp [testify]: https://github.com/stretchr/testify
cceckman
reviewed
Sep 11, 2024
cceckman
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the third copy-paste of assertEqual, I think it's time to make an internal test assertion library.
This is similar to testify's assert package, mostly because it's the one I'm most familiar with.
This now uses go-cmp instead of
reflect.DeepEqualfor comparing values. We get free diff reports out of it too!I added the package to a new
internaldirectory to make it clear that this isn't part of the application itself. It also prevents it from being imported from anywhere else, even though there's no reason to import from this module anyway.