[WIP] Add WF for appending additional images #25
Conversation
| - name: Perform tests | ||
| run: | | ||
| echo "Performing functional tests" |
There was a problem hiding this comment.
For now this is just a place holder until we can set up some proper tests.
| git config --global user.email "[email protected]" | ||
| git config --global user.name "codeflare-machine-account" |
There was a problem hiding this comment.
small nit, can we put these in the env vars too?
| git config --global user.name "codeflare-machine-account" | ||
| git checkout -b $UPDATE_BRANCH | ||
| # Update the image list to include the fms-hf-tuning release image | ||
| export IMAGE_SHA=$(podman pull --quiet quay.io/$IMAGE_BASE/$IMAGE_REPO:release) |
There was a problem hiding this comment.
Is there any way to do this without pulling the whole image? The image is 3.3Gb which is relatively large.
| git add . | ||
| git commit -am "Updated rhoai-disconnected-images.yaml with latest fms-hf-tuning release image" --signoff | ||
| git push origin $UPDATE_BRANCH | ||
| git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/$REPO_OWNER/$REPO_NAME.git |
There was a problem hiding this comment.
What is this line doing? Is this so that the WF is authenticated when creating the PR?
There was a problem hiding this comment.
Yes it is for authentication purposes for the gh create pr command
There was a problem hiding this comment.
Can you move it down to that step just so they are linked?
| podman tag quay.io/$IMAGE_BASE/$IMAGE_REPO:release quay.io/$IMAGE_BASE/$IMAGE_REPO:$RHOAI_BRANCH | ||
| podman push quay.io/$IMAGE_BASE/$IMAGE_REPO:$RHOAI_BRANCH |
There was a problem hiding this comment.
| podman tag quay.io/$IMAGE_BASE/$IMAGE_REPO:release quay.io/$IMAGE_BASE/$IMAGE_REPO:$RHOAI_BRANCH | |
| podman push quay.io/$IMAGE_BASE/$IMAGE_REPO:$RHOAI_BRANCH | |
| podman push quay.io/$IMAGE_BASE/$IMAGE_REPO:release | |
| quay.io/$IMAGE_BASE/$IMAGE_REPO:$RHOAI_BRANCH |
I think this should work with just a single line
There was a problem hiding this comment.
Wow that's really cool I didn't know you could do that! Thanks
riprasad
force-pushed
the
main
branch
5 times, most recently
from
82372de
to
5a99925
Compare
Description of the change
Added a workflow which appends the image list in rhoai-additional-images with the latest release of the fms-hf-tuning image and creates an automated Pull Request after successful tests are performed.
This workflow will also push a rhoai-xxx tagged version of the working release image.
Related issue number
Closes: RHOAIENG-9937
How to verify the PR
Run the Workflow in Github actions.
After specifying the version of RHOAI you want. A PR should be made to rhoai-additional-images with the latest release image SHA appended to the image list of the given rhoai-xxx branch.
A rhoai-xxx tag of the release image should be pushed to
modh/fms-hf-tuningin Quay.TODO
Add CF Machine account credentials to this repo
Add Quay credentials to this repo
Add testing step to the workflow
Note: you can run this WF with
gh workflow run fms-additonal-image-push.yaml -R github.com/redhat-data-services/fms-hf-tuning -f rhoai-release-version=2.xxWas the PR tested
I have tested this workflow on my forked repositories and private quay repo.