Skip to content

Commit

Permalink
fix: Replace "foo" string with a less generic one (kserve#465)
Browse files Browse the repository at this point in the history
If template parsing fails, the "foo" string would appear in pod logs.
This should be very hard to happen, since the template is built-in.
Changing, simply, to have more meaningful logs.

Fixes opendatahub-io#114

Signed-off-by: Edgar Hernández <[email protected]>
  • Loading branch information
israel-hdez authored Jan 18, 2024
1 parent 5f9c6f7 commit a2ce947
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controllers/config/templating.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func templateSource(r io.Reader, context interface{}) mf.Source {
if err != nil {
panic(err)
}
t, err := template.New("foo").Parse(string(b))
t, err := template.New("ModelMeshTemplate").Parse(string(b))
if err != nil {
panic(err)
}
Expand Down

0 comments on commit a2ce947

Please sign in to comment.