Skip to content

Commit

Permalink
RHOAIENG-17368: chore(release): update the package versions script wi…
Browse files Browse the repository at this point in the history
…th 2.16.1 support changes

Also remove outdated todos which are already done.
  • Loading branch information
jiridanek committed Jan 30, 2025
1 parent 1aeb534 commit b929857
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions ci/package_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,6 @@
"""Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs
using the Markdown variant described at https://access.redhat.com/articles/7056942"""

"""
TODO:
* separate reading data and printing output
so that output can be properly sorted (by opendatahub.io/notebook-image-order probably)
* don't repeat image name when printing multiple tags for it
* run this in red-hat-data-services repo so we also have (or not have) Habana image
* diff it with what's in the knowledge base now, to check if outputs match
"""

ROOT_DIR = pathlib.Path(__file__).parent.parent


Expand Down Expand Up @@ -130,7 +121,8 @@ def main():
sw_version = sw_version.lstrip("v")
software.append(f"{sw_name}: {sw_version}")

maybe_techpreview = "" if name not in ('code-server',) else " (Technology Preview)"
# in 2.16.1 we only have RStudio as tech preview, and that is not a prebuilt image we ship
maybe_techpreview = "" if name not in () else " (Technology Preview)"
maybe_recommended = "" if not recommended or len(imagestream.tags) == 1 else ' (Recommended)'

tabular_data.append((
Expand Down Expand Up @@ -159,6 +151,7 @@ def main():
print(f'{row[0]} | {row[1]} | {row[2]}')
print('```')


class TestManifest(unittest.TestCase):
_data = yaml.safe_load(io.StringIO(package_versions_selftestdata.imagestream))
manifest = Manifest(_data)
Expand Down

0 comments on commit b929857

Please sign in to comment.