-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BuildConfiguration objects to build RStudio and CUDA R RStudio notebooks oc OCP cluster #118
Add BuildConfiguration objects to build RStudio and CUDA R RStudio notebooks oc OCP cluster #118
Conversation
260c9cc
to
ff485b3
Compare
What's RHOAI 2.7 going to do? The second option? So when I install the Operator, it will automatically deploy the buildconfigs for me, so I then need to create |
0eb062b
to
c2b5b35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussions, we can perhaps include additional details on the imagestream, so user can directly use these in the RHOAI dashboard
PTAL at suggestions
c2b5b35
to
d850634
Compare
d850634
to
1698067
Compare
Created this PR #127 with two fixes on the CUDA Dockerfile |
7466816
to
aa8cfde
Compare
8cde95a
to
2eff051
Compare
@atheo89 , if we switch to ARG, then we might have to pass in the buildarg on buildconfig:https://docs.openshift.com/container-platform/3.11/dev_guide/builds/build_strategies.html#docker-strategy-build-args |
I will add ENVs on the Dockerfiles as it was |
…es on OCP cluster
2eff051
to
3e1b267
Compare
3e1b267
to
ac0c6ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks for the work 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes:
https://issues.redhat.com/browse/RHOAIENG-1478
https://issues.redhat.com/browse/RHOAIENG-315
This pull request introduces two BuildConfig objects, enabling users to create an RStudio Workbench on their cluster.
The branch that hosts the RStudio dockerfile is hosted on f/rstudio-rhel9 branch
Probably a good enhancement on this implementation is to, have prebuild the base-rhel9 image in order to avoid its build all the time. This enchancment has already stated on this PR: #123 However, this implementation it stand alone as is now.
How has been Tested
There are two ways to deploy the new Build Configs
The first and the recommended is (Deploy the configs outside from RHOAI):
Login on the cluster:
oc login <ocp cluster url>
Enter on
redhat-ods-applications
namespace if you use RHOAI oropendatahub
if you use ODHoc project redhat-ods-applications
Create a secret, PM me to provide you testing credentials:
oc create secret generic rhel-subscription-secret --from-literal=USERNAME=<username> --from-literal=PASSWORD=<pass> --from-literal=BASEURL=<baseurl> --from-literal=SERVERURL=<serverurl> -n redhat-ods-applications
Run the
rstudio-buildconfig.yaml
file to to deploy the simple version of RStudio:oc apply -f rstudio-buildconfig.yaml -n redhat-ods-applications
Or run the
cuda-rstudio-buildconfig.yaml
to build the CUDA version of RStudio:oc apply -f cuda-rstudio-buildconfig.yaml-n redhat-ods-applications
After creating all the objects, navigate to the BuildConfig and initiate the build process as illustrated in the image:
Once the builds are complete means that the RStudio workbench is ready
To add Workbench to the list of notebooks, start by obtaining the image from the rstudio-rhel9 Image Stream and importing it as a custom notebook, following the instructions in the image below:
Spin up the workbench that you just created
The second way is (Deploy the configs inside RHOAI, as it is implemented already):
Create a secret, PM me to provide you testing credentials:
oc create secret generic rhel-subscription-secret --from-literal=USERNAME=<username> --from-literal=PASSWORD=<pass> --from-literal=BASEURL=<baseurl> --from-literal=SERVERURL=<serverurl> -n redhat-ods-applications
Follow the same steps from (5) till the end