Review Dockerfile changes for building odh-dashboard in Konflux #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes can merge into |
|
|
@andrewballantyne I have sent an email with details of why we want to keep these files to downstream for 2.16 version, please let me know if you have any queries. |
|
Nothing can merge to main -- you'll break the auto merger, no? @dchourasia Everything has to merge upstream first to continue the fast forward effort. Why are we trying to open up PRs directly to downstream? |
|
@andrewballantyne it's other way round.. auto-merge will fail if we add these files to upstream. Please check the details I have provided on email and Jira both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #https://issues.redhat.com/browse/RHOAIENG-14049