-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle: adjust for Konflux onboarding, 2.8 #2322
base: rhoai-2.8
Are you sure you want to change the base?
bundle: adjust for Konflux onboarding, 2.8 #2322
Conversation
c81528e
to
59c1069
Compare
59c1069
to
52f6709
Compare
Will it be what is expected in the final result? That moment, when it should be squashed :) |
@@ -1,27 +0,0 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we deleted this file? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in Jira request. How is that supposed to be used? Our manager is configured with command line as a part of Deployment in CSV, isn't it?
I see mounts of manager-config
ConfigMap in some other manifests, but not redhat-ods-operator-manager-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comments for the CM file, otherwise LGTM
/cc @dchourasia |
Prepare for konflux build. Since the latest shipped version is in CPaaS, sync with it. kueue: default Removed trustyai: deprecated Signed-off-by: Yauheni Kaliuta <[email protected]>
Prepare for konflux build. Since the latest shipped version is in CPaaS, sync with it. descriptions: add final periods servicemesh: default Managed customCABundle: required Signed-off-by: Yauheni Kaliuta <[email protected]>
Prepare for konflux build. Signed-off-by: Yauheni Kaliuta <[email protected]>
Prepare for konflux build. Signed-off-by: Yauheni Kaliuta <[email protected]>
Prepare for konflux build. Sync with CPaaS. Commit CPaaS version as is before adjusting to konflux. Signed-off-by: Yauheni Kaliuta <[email protected]>
Replace variables values with placehoulders - name (rhods-operator.NAME) - containerImage (REPLACE_IMAGE:latest) - createdAt (REPLACE_DATE) - version (REPLACE_VERSION) - image (REPLACE_IMAGE:latest) Remove "RELATED_IMAGE*" environment variables. Remove images from annotations. Removed fields: - replaces - olm.skipRange Signed-off-by: Yauheni Kaliuta <[email protected]>
52f6709
to
9d1d4a3
Compare
Jira: https://issues.redhat.com/browse/RHOAIENG-18669
For CSV Take CPaaS manifests and remove template variables
For other manifests, fetch minor differences from CPaaS
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria