-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test automation for reclaimspace disable operation #10862
base: master
Are you sure you want to change the base?
Adding test automation for reclaimspace disable operation #10862
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paraggit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5b5adff
to
50e7f13
Compare
self.pod_objs.append(pod_obj) | ||
|
||
# Disable Reclaimspace operation for the PVC | ||
log.info("Changing reclaimspace cronjob status to disable for all PVC object.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something but if we want to disable the reclaim space, don't we need to enable it first?
If it is enabled by default then it is valid.
If not you are disabling but then enabling. I think it should go the other way around.
Enable->disable and then you can enable it back if we want to see that it can be reversed again to enable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reclaimspace is enabled by default on the cluster, so the flow starts with disabling and then enabling it to test reversibility.
tests/functional/pv/space_reclaim/test_disable_reclaimspace_operation.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Parag Kamble <[email protected]>
b49c6f5
to
a480f54
Compare
Signed-off-by: Parag Kamble <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the test it only checks configuration but there is no validation if the reclaim has stopped happening. Is there a way to expand the testcase to really check if the functionality has stopped working? Something like fill the PVC with data that will be seen in the whole storage capacity and delete the data within the PVC and see that the space in not reclaimed like it should be when reclaim space is enabled. From your experience how much time it takes for space to be reclaimed?
Adding test automation for reclaimspace disable operation