Run sanity checks on PR base branch change #1715
Conversation
alfonsomthd
force-pushed
the
on-base-change
branch
from
aef1519 to
2cb9197
Compare
alfonsomthd
changed the title
alfonsomthd
force-pushed
the
on-base-change
branch
from
ac1c02b to
e65b03b
Compare
alfonsomthd
changed the title
alfonsomthd
force-pushed
the
on-base-change
branch
from
e65b03b to
d7c0891
Compare
alfonsomthd
requested review from
bipuladh,
GowthamShanmugam and
SanjalKatiyar
| on: | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
| branches: [master, release*] | ||
| types: [opened, synchronize, reopened, edited] |
There was a problem hiding this comment.
The event types preceding edited are the default ones.
There was a problem hiding this comment.
what is When updating the base branch, no sanity-checks are run means?
There was a problem hiding this comment.
Currently (before this PR), when you change the base branch (i.e. from master to release-.x.x) the sanity checks (build, lint, unit tests, etc) are not run, only the E2E tests.
|
/retest |
|
/approve |
|
cc: @SanjalKatiyar and @bipuladh to tag |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2d49e49
into
red-hat-storage:master
@SanjalKatiyar @bipuladh ping. |
Please ignore the ping. |
|
/cherrypick release-4.18 release-4.18-compatibility |
|
@alfonsomthd: new pull request created: #1733 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.17 |
|
/cherry-pick release-4.17-compatibility |
|
/cherry-pick release-4.16 |
|
/cherry-pick release-4.16-compatibility |
|
@alfonsomthd: new pull request created: #1734 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alfonsomthd: new pull request created: #1735 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.15 |
|
/cherry-pick release-4.15-compatibility |
|
/cherry-pick release-4.14 |
|
@alfonsomthd: new pull request created: #1736 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.14-compatibility |
|
@alfonsomthd: new pull request created: #1737 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alfonsomthd: new pull request created: #1738 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alfonsomthd: new pull request created: #1739 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@alfonsomthd: #1715 failed to apply on top of branch "release-4.14-compatibility": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18-compatibility |
|
@alfonsomthd: new pull request created: #1742 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The pull_request
editedevent type is the only one that detects a change in the base branch, so we're adding it to the list of event types to prevent the following scenarios:NOTE: the side effect is when editing the title or PR description, sanity-checks will be re-triggered. Although not ideal, it's better than adding a condition on the job to not run it on title/description changes, as the job is marked as skipped: misleading (we don't know if the previous run was successful or not).