Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-978: csi: disable fencing in Rook #794

Merged

Conversation

subhamkrai
Copy link

Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna [email protected]
(cherry picked from commit 1d1ed5e) (cherry picked from commit 34f81ec) (cherry picked from commit fc94e11)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit 1d1ed5e)
(cherry picked from commit 34f81ec)
(cherry picked from commit fc94e11)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978), which is invalid:

  • expected the bug to target the "odf-4.16.4" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna [email protected]
(cherry picked from commit 1d1ed5e) (cherry picked from commit 34f81ec) (cherry picked from commit fc94e11)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@subhamkrai
Copy link
Author

subhamkrai commented Dec 17, 2024

@travisn do I need fix the govulncheck ci btw errors are not related the PR

@travisn
Copy link

travisn commented Dec 17, 2024

@travis do I need fix the govulncheck ci btw errors are not related the PR

No, let's not worry about the unrelated ci failures in the older branches.

@subhamkrai
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978), which is invalid:

  • expected the bug to target the "odf-4.16.4" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@subhamkrai
Copy link
Author

@subhamkrai: This pull request references [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978), which is invalid:

  • expected the bug to target the "odf-4.16.4" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

@sunilheggodu next 4.16 z release is 4.16.5 right? how we can fix this bot comment? The Jira bug has Target Release: 4.16.5 set

@sunilheggodu
Copy link

@subhamkrai: This pull request references [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978), which is invalid:

  • expected the bug to target the "odf-4.16.4" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

@sunilheggodu next 4.16 z release is 4.16.5 right? how we can fix this bot comment? The Jira bug has Target Release: 4.16.5 set

As the Bug is now Targeted for 4.16.6 lets wait for the approval. once approval is received we can merge it

@subhamkrai
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025

@subhamkrai: This pull request references [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.16.6) matches configured target version for branch (odf-4.16.6)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@subhamkrai subhamkrai requested a review from travisn January 9, 2025 16:01
@travisn
Copy link

travisn commented Jan 9, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@subhamkrai subhamkrai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: subhamkrai, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhamkrai subhamkrai merged commit 84355fb into red-hat-storage:release-4.16 Jan 10, 2025
45 of 49 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025

@subhamkrai: [Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-978](https://issues.redhat.com//browse/DFBUGS-978) has been moved to the MODIFIED state.

In response to this:

Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna [email protected]
(cherry picked from commit 1d1ed5e) (cherry picked from commit 34f81ec) (cherry picked from commit fc94e11)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants