Command support in crux_kv and tweaks and fixes to the Command API to enable the capability migration #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new module called
commandtocrux_kvwhich provides KV command builder constructors.Because KV presents a different interface to the core than the protocol it has with the shell, it needs to do post-processing_ on the results. I took the opportunity to add
.maptoRequestBuilderandStreamBuilder. I also made some missed out parts of this API public incrux_core.This should put is in a good place to tackle more complicated capabilities.
note: this will require a patch release of
crux_coreand therefore a patch release ofcrux_kv(and potentially all capabilities - haven't thought about that too hard)