Skip to content

Commit

Permalink
minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
novanai committed Jan 15, 2025
1 parent 207b92d commit 67365d9
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/extensions/xkcd.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ async def xkcd_command(
flags=hikari.MessageFlag.EPHEMERAL,
)
return

response = await query.json()
max_comic = response["num"]

num = random.randint(1, max_comic)

base_url = "https://xkcd.com/"
page_url = f"{base_url}{num}/"
api_url = f"{page_url}info.0.json"
page_url = f"https://xkcd.com/{num}"
api_url = f"{page_url}/info.0.json"

async with aiohttp_client.get(api_url) as response:
if response.status != 200:
Expand All @@ -42,11 +43,15 @@ async def xkcd_command(
flags=hikari.MessageFlag.EPHEMERAL,
)
return

data = await response.json()

# sometimes transcript is an empty string
transcript_text = t if (t := data["transcript"]) else "No transcript available."

embed = hikari.Embed(
title=data["title"],
description=data["transcript"] if transcript else "",
description=transcript_text if transcript else None,
url=page_url,
)
embed = embed.set_image(data["img"])
Expand Down

0 comments on commit 67365d9

Please sign in to comment.