switch to using react hooks and functional components #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frazl
requested changes
Dec 16, 2019
| <h2> | ||
| {isEventsPage ? 'View our latest events here!' : "We are DCU's Computer Networking Society"} | ||
| </h2> | ||
| <ImageGrid images={images} /> |
There was a problem hiding this comment.
This needs to be changed to check if images have been passed. Gives an error currently on /events.
There was a problem hiding this comment.
Also appears as if committee photos aren't loading at all?
There was a problem hiding this comment.
fixed i had moved the image check inside the component but forgot to return an empty component
There was a problem hiding this comment.
committee is working locally for me any console error?
There was a problem hiding this comment.
No errors, just not appearing with their photos, only rb logo
There was a problem hiding this comment.
I Added a fall back if photos isn't specified to fall back to brick, is it just appearing for blank profiles or all?
This was referenced Dec 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr is rather large because react hooks a quite different but they result in far less boilerplate and more easily understood code.
As part of this PR, I also removed the style of map and push in favour of pure maps as this is far simpler and more efficient.
This PR closes #16 #14 #15 #13 #11 #9 #8 #7 #6 #5 #4 #3 and #1
It also Makes it possible to stop using stock images ala #12
and fixes some of the issues listed in #10