Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-controller update #3838

Merged
merged 2 commits into from
Jun 7, 2024
Merged

image-controller update #3838

merged 2 commits into from
Jun 7, 2024

Conversation

@openshift-ci openshift-ci bot requested review from mkosiarc and rcerven June 3, 2024 10:21
Copy link
Member

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorhun, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@mmorhun
Copy link
Member

mmorhun commented Jun 3, 2024

/hold

@mmorhun
Copy link
Member

mmorhun commented Jun 3, 2024

/test appstudio-e2e-tests

@mmorhun
Copy link
Member

mmorhun commented Jun 4, 2024

We've got valid test failures:

1. Red Hat App Studio E2E tests: [It] [remotesecret-suite] SVPI-574 and SVPI-652 - Ensure existence of image pull remote secret, image push remote secret, image pull secret and image push secret when ImageRepository is created checks if image repository is ready 
2. Red Hat App Studio E2E tests: [It] [remotesecret-suite] SVPI-601 - Ensure existence of image pull remote secret and image pull secret when component is created checks if image pull remote secret was deployed [remote-secret, component-annotation-image-pull-remote-secret 

@mshaposhnik
Copy link
Contributor

/retest

@mshaposhnik
Copy link
Contributor

/retest-required

2 similar comments
@mshaposhnik
Copy link
Contributor

/retest-required

@mshaposhnik
Copy link
Contributor

/retest-required

@mmorhun
Copy link
Member

mmorhun commented Jun 6, 2024

/test appstudio-e2e-tests

@mshaposhnik
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Jun 7, 2024

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests ca932a2 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkosiarc
Copy link
Member

mkosiarc commented Jun 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@mshaposhnik mshaposhnik merged commit 6f21a7d into main Jun 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants