-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(KFLUXVNGD-88): Add crossplane component #4855
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hmariset The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
9cd296b
to
c8cc097
Compare
Moved to a draft state until konflux-ci/crossplane-control-plane#1 is merged. |
c8cc097
to
dc74a72
Compare
dc74a72
to
bd8720f
Compare
@hmariset When running the kustomization file locally, we are getting the same error. |
Yes Avi, I'm working on it. I checked a documentation to add confimap to mitigate this error, will update the PR soon. |
6c969a1
to
a43c031
Compare
...s/base/all-clusters/infra-deployments/crossplane-control-plane/crossplane-control-plane.yaml
Outdated
Show resolved
Hide resolved
3a6767c
to
a953899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need a similar change to path as this one for both production environment, here is how it should look like:
diff --git a/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml b/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
index 1c614516..52245898 100644
--- a/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
+++ b/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
@@ -181,3 +181,8 @@ patches:
kind: ApplicationSet
version: v1alpha1
name: proactive-scaler
+ - path: production-overlay-patch.yaml
+ target:
+ kind: ApplicationSet
+ version: v1alpha1
+ name: crossplane-control-plane
diff --git a/argo-cd-apps/overlays/production-downstream/kustomization.yaml b/argo-cd-apps/overlays/production-downstream/kustomization.yaml
index af361355..76bbde99 100644
--- a/argo-cd-apps/overlays/production-downstream/kustomization.yaml
+++ b/argo-cd-apps/overlays/production-downstream/kustomization.yaml
@@ -197,3 +197,8 @@ patches:
kind: ApplicationSet
version: v1alpha1
name: proactive-scaler
+ - path: production-overlay-patch.yaml
+ target:
+ kind: ApplicationSet
+ version: v1alpha1
+ name: crossplane-control-plane
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to create a folder for staging and production since the application is getting deployed to all 3 environments with this change
07d1c36
to
f4b4f3b
Compare
2e24e6e
to
d7148cb
Compare
@hmariset I took your changes, made some adjustments, and managed to successfully deploy crossplane to OCP. Please incorporate these. I also created cluster type overlays for vanilla k8s and OCP. Please take a look at konflux-ci/crossplane-control-plane#2. If and when that gets merged the ref in the aforementioned commit should be updated so that it no longer points to my fork of crossplane-control-plane. |
Initial crossplane component is added in the components of the infra-deployments. Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-88 Signed-off-by: Homaja Marisetty <[email protected]>
d7148cb
to
6c82fb4
Compare
Initial crossplane component is added in the components of the infra-deployments.
Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-88