Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXVNGD-88): Add crossplane component #4855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hmariset
Copy link
Contributor

@hmariset hmariset commented Nov 6, 2024

Initial crossplane component is added in the components of the infra-deployments.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-88

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hmariset
Once this PR has been reviewed and has the lgtm label, please assign manish-jangra for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avi-biton
Copy link
Contributor

/retest

@amisstea
Copy link
Contributor

amisstea commented Nov 7, 2024

Moved to a draft state until konflux-ci/crossplane-control-plane#1 is merged.

@avi-biton
Copy link
Contributor

@hmariset
We are getting this error:
loading generator plugins: failed to load generator: plugin HelmChartInflationGenerator.builtin.[noGrp]/crossplane.[noNs] fails configuration: must specify --enable-helm

When running the kustomization file locally, we are getting the same error.
In order to overcome it when running it manually, we use the --enable-helm flag in the kustomization file.
We should check how to overcome it in our configuration

@hmariset
Copy link
Contributor Author

@hmariset We are getting this error: loading generator plugins: failed to load generator: plugin HelmChartInflationGenerator.builtin.[noGrp]/crossplane.[noNs] fails configuration: must specify --enable-helm

When running the kustomization file locally, we are getting the same error. In order to overcome it when running it manually, we use the --enable-helm flag in the kustomization file. We should check how to overcome it in our configuration

Yes Avi, I'm working on it. I checked a documentation to add confimap to mitigate this error, will update the PR soon.

@hmariset hmariset force-pushed the crossplane-KFLUXVNGD-88 branch 2 times, most recently from 6c969a1 to a43c031 Compare November 12, 2024 16:48
@hmariset hmariset force-pushed the crossplane-KFLUXVNGD-88 branch 2 times, most recently from 3a6767c to a953899 Compare November 12, 2024 19:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a similar change to path as this one for both production environment, here is how it should look like:

diff --git a/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml b/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
index 1c614516..52245898 100644
--- a/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
+++ b/argo-cd-apps/overlays/konflux-public-production/kustomization.yaml
@@ -181,3 +181,8 @@ patches:
       kind: ApplicationSet
       version: v1alpha1
       name: proactive-scaler
+  - path: production-overlay-patch.yaml
+    target:
+      kind: ApplicationSet
+      version: v1alpha1
+      name: crossplane-control-plane
diff --git a/argo-cd-apps/overlays/production-downstream/kustomization.yaml b/argo-cd-apps/overlays/production-downstream/kustomization.yaml
index af361355..76bbde99 100644
--- a/argo-cd-apps/overlays/production-downstream/kustomization.yaml
+++ b/argo-cd-apps/overlays/production-downstream/kustomization.yaml
@@ -197,3 +197,8 @@ patches:
       kind: ApplicationSet
       version: v1alpha1
       name: proactive-scaler
+  - path: production-overlay-patch.yaml
+    target:
+      kind: ApplicationSet
+      version: v1alpha1
+      name: crossplane-control-plane

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to create a folder for staging and production since the application is getting deployed to all 3 environments with this change

@hmariset hmariset force-pushed the crossplane-KFLUXVNGD-88 branch 4 times, most recently from 07d1c36 to f4b4f3b Compare November 13, 2024 02:38
@hmariset hmariset force-pushed the crossplane-KFLUXVNGD-88 branch 20 times, most recently from 2e24e6e to d7148cb Compare November 14, 2024 16:01
@amisstea
Copy link
Contributor

@hmariset I took your changes, made some adjustments, and managed to successfully deploy crossplane to OCP. Please incorporate these.

I also created cluster type overlays for vanilla k8s and OCP. Please take a look at konflux-ci/crossplane-control-plane#2. If and when that gets merged the ref in the aforementioned commit should be updated so that it no longer points to my fork of crossplane-control-plane.

Initial crossplane component is added in the components
of the infra-deployments.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-88
Signed-off-by: Homaja Marisetty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants