Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-platform-controller update #5319

Merged
merged 1 commit into from
Jan 26, 2025
Merged

multi-platform-controller update #5319

merged 1 commit into from
Jan 26, 2025

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Jan 20, 2025 •
edited
Loading

Included PRs:

@openshift-ci openshift-ci bot requested review from arewm and ifireball January 20, 2025 08:52
@rh-tap-build-team rh-tap-build-team bot force-pushed the multi-platform-controller branch 13 times, most recently from 8187f97 to d26e1f9 Compare January 26, 2025 11:47
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 26, 2025

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests 5397e96 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ifireball
ifireball approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ifireball, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac2654f into main Jan 26, 2025
5 of 6 checks passed
@ifireball ifireball deleted the multi-platform-controller branch January 26, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifireball ifireball ifireball approved these changes

@arewm arewm Awaiting requested review from arewm

Assignees

@ifireball ifireball

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifireball