Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move up ArgoCD CRs to v1beta1 API version #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Nov 7, 2023

Description:

  • Latest version of OpenShift GitOps has a new API version v1beta1 for ArgoCD resource.
  • Since there are issues with the conversion between the versions, it seems easiest to move to the new version.

Link to JIRA Story (if applicable): N/A

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.14%. Comparing base (5b73d70) to head (fea68c2).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   63.15%   63.14%   -0.02%     
==========================================
  Files         102      102              
  Lines       18535    18535              
==========================================
- Hits        11706    11704       -2     
- Misses       5550     5551       +1     
- Partials     1279     1280       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgwest jgwest removed the request for review from chetan-rns November 15, 2023 05:13
@jgwest
Copy link
Member Author

jgwest commented Nov 15, 2023

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant