feat: Add option to bypass subscriptions creation #433
+43
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviof
approved these changes
Feb 4, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: otaviof, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Clusters might already have subscriptions installed, which would trigger an error in Helm as it did not control the resources. A new flag is added to disable the subscription installation per product, with the following limitations: - AMQ Streams is controlled by TPA - CrunchyData is controlled by RHDH and TPA Those limitations means that a user may need to install some subscription manually (eg if they already have AMQ Streams, TPA must be installed manually and the `managedSubscription` flag must be set to `false`). cf RHTAP-4063 rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Roming22
force-pushed
the
feat/subscriptions
branch
from
46daac0 to
107b71f
Compare
|
New changes are detected. LGTM label has been removed. |
|
|
/retest |
1 similar comment
|
/retest |
|
@Roming22: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-kp268Test results analysis<not enabled> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clusters might already have subscriptions installed, which would trigger an error in Helm as it did not control the resources.
A new flag is added to disable the subscription installation per product, with the following limitations:
Those limitations means that a user may need to install some subscription manually (eg if they already have AMQ Streams, TPA must be installed manually and the
managedSubscriptionflag must be set tofalse).cf RHTAP-4063
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED