-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local policy.yaml file for Enterprise Contract #42
base: main
Are you sure you want to change the base?
Use local policy.yaml file for Enterprise Contract #42
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simonbaird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rather than maintain a dependency on the ec configs at https://github.com/enterprise-contract/config let's use our own local config. Notice that it uses a stable branch of the ec-policies repo rather than main branch. This is to reduce the change of unexpected breakages as new things are added to the ec-policies repo main branch. Ref: https://issues.redhat.com/browse/EC-605
e6a3aab
to
12f178a
Compare
This is an alternative to #40. I think it's better since it removes the dependency on that enterprise-contract/config repo. |
Another option would be to create a separate git repo just for the policy.yaml file. |
@simonbaird: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As per slack discussion, the plan is to move forward with #40 in the short term, and revisit this in future. Converting to draft. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rather than maintain a dependency on the ec configs at https://github.com/enterprise-contract/config let's use our own local config.
Notice that it uses a stable branch of the ec-policies repo rather than main branch. This is to reduce the change of unexpected breakages as new things are added to the ec-policies repo main branch.
Ref: https://issues.redhat.com/browse/EC-605