-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the 'aap_rules_validation' role #16
Conversation
I wonder if the name shouldn't have controller in the name if the plan is in the future to support all the components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work with this! This will be very useful for many people for sure!
I only have to ask for two amends and the addition of a changelog fragment.
roles/aap_rules_validation/tasks/check_credentials_encryption.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can merge once you fix the linting/pre-commit errors (the current ansible ones are expected so you can ignore those)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Introduce a new role :
aap_rules_validation
An ansible role which audit the declared AAP configuration and validate it against a set of user-defined rules.
How should this be tested?
Two test playbooks are delivered with the role under the folder
tests/playbooks
:aap_rules_validation_filetree_read.yml
aap_rules_validation_include.yml
A set of example rules to test against are available under
tests/configs/controller_rules.yml
Is there a relevant Issue open for this?
n/a
Other Relevant info, PRs, etc
I demoed this role during the community of practice meeting under the controller_policy name which was rectified to adapt to the AAP strategy.