-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup plan role #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the tests to be executed, you need to add an aliases
file with cloud/aws
tests/integration/targets/test_backup_create_plan/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_backup_select_resources/tasks/main.yml
Outdated
Show resolved
Hide resolved
It doesn't look like the other test targets in this repo have that, why is it needed for these? What does |
The |
64d4577
to
6440eb3
Compare
@abikouo do you know why the test_customized_ami test is failing? I rebased this branch onto main today so it should have the latest changes. |
@hakbailey the integration target is failing because of missing required RSA keys. I have created a PR to fix that #48 |
@hakbailey Please update also https://github.com/redhat-cop/cloud.aws_ops#roles because it is not automatically generated. |
707419f
to
a648316
Compare
@hakbailey need target are not executed, I am going to investigate why |
e1ae4aa
to
1cb6fda
Compare
@abikouo any updates on this? |
The integration workflow does not checkout the pull request head branch this is the reason why the new target is not visible by |
SUMMARY
Adds roles to create a backup plan/vault and to select resources for backup.
ISSUE TYPE
COMPONENT NAME
backup_create_plan
backup_select_resources