Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration test test_manage_vpc_peering #67

Closed
wants to merge 2 commits into from

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 26, 2023

Pull request #44 has been merged while integration tests are not running on the pull request head branch.
The test target is broken, here are some fixes:

  • add aliases file with cloud/aws allowing ansible-test command to provide aws credentials to run tests
  • role/manage_vpc_peering does not read right credentials variable from aws_setup_credentials role

Some feature have been added

  • Test VPC peering statuses: deleted, active

@gravesm
Copy link
Member

gravesm commented Jul 26, 2023

There is already an existing PR #61 for this. Can you please close this one and review that one?

@abikouo
Copy link
Contributor Author

abikouo commented Jul 26, 2023

There is already an existing PR #61 for this. Can you please close this one and review that one?

I have reviewed the existing one, I will close that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants