Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators-installer - updates #347

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Jul 15, 2023

What is this PR About?

  • add control over approver job time out because saw case where exceeded but otherwise would have worked
  • add default argo sync waves because saw case where argo synced Job before ServiceAccount, Role, RoleBinding causing the approver job to error
  • cleaned up sample lua health check in README.md

How do we test this?

ran helm template against new test file.

cc: @redhat-cop/day-in-the-life

…dd default argo sync waves so that SA gets created before approver job. Clean up sample subscription health check
@eformat eformat merged commit 5f1fa80 into redhat-cop:master Jul 16, 2023
2 checks passed
@eformat
Copy link
Contributor

eformat commented Jul 16, 2023

LGTM ! cheers

@itewk itewk deleted the feature/operators-installer-fix5 branch July 16, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants