Fix for Syntax Error in Sample Code Snippet #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redhat-cop/day-in-the-life i dont have access to merge stuff myself, can someone else merge this please? |
|
thanks for the PR @manish-jangra 🚀 |
|
Thanks, everyone, this really helped me to create custom health checks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
There was a syntax error in the code snippet
charts/operators-installer/README.mdprovided for configuring custom health checks for operators.How do we test this?
I tested this in a local environment by installing external-secrets-operator with
installPlanApprovalsetManualand it reported the deployment as Healthy because of the following conditionAfter the operator was deployed in Cluster using ArgoCD,
condition.typewas set toInstallPlanPendingandcondition.statuswas set toTruewithout approving the installPlan manually.cc: @redhat-cop/day-in-the-life