Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Remove duplicate warning about Web Sockets #278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove duplicate warning about Web Sockets #278

wants to merge 2 commits into from

Conversation

mbach04
Copy link

@mbach04 mbach04 commented May 31, 2018

What is this PR About?

Duplicate warning in the docs about web sockets

How should we test or review this PR?

None, purely documentation.

Is there a relevant Trello card or Github issue open for this?

no

Who would you like to review this?

cc: @redhat-cop/cant-contain-this

Copy link
Contributor

@lpsantil lpsantil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch but dupe also happens as line 113.

etsauer
etsauer previously approved these changes Jul 20, 2018
@etsauer etsauer dismissed their stale review July 20, 2018 14:29

Missed something

@etsauer
Copy link
Contributor

etsauer commented Jul 20, 2018

@mbach04 can you address @lpsantil 's comment above?

@JaredBurck
Copy link
Contributor

@mbach04 any updates?

@mbach04
Copy link
Author

mbach04 commented Sep 15, 2018

Sorry guys, I pulled a fly by PR on this one! I removed the additional duplicate and pushed to the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants