-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(): add CRD for GCPAuthEngineConfig #242
base: main
Are you sure you want to change the base?
Changes from 6 commits
8719320
71709c7
6e9ec0c
8f0551b
4116f3b
2116812
960251c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -425,4 +425,4 @@ resources: | |
defaulting: true | ||
validation: true | ||
webhookVersion: v1 | ||
version: "3" | ||
version: "3" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -363,4 +363,4 @@ spec: | |
served: true | ||
storage: true | ||
subresources: | ||
status: {} | ||
status: {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,9 +89,9 @@ webhooks: | |
service: | ||
name: webhook-service | ||
namespace: system | ||
path: /mutate-redhatcop-redhat-io-v1alpha1-databasesecretengineconfig | ||
path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthengineconfig | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this correct, it seems you are replacing the databasesecretengineconfig, this file is automatically generated, just run |
||
failurePolicy: Fail | ||
name: mdatabasesecretengineconfig.kb.io | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also these substitutions look suspicious, please regenerate this file with |
||
name: mgcpauthengineconfig.kb.io | ||
rules: | ||
- apiGroups: | ||
- redhatcop.redhat.io | ||
|
@@ -100,7 +100,26 @@ webhooks: | |
operations: | ||
- CREATE | ||
resources: | ||
- databasesecretengineconfigs | ||
- gcpauthengineconfigs | ||
sideEffects: None | ||
- admissionReviewVersions: | ||
- v1 | ||
clientConfig: | ||
service: | ||
name: webhook-service | ||
namespace: system | ||
path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthenginerole | ||
failurePolicy: Fail | ||
name: mgcpauthenginerole.kb.io | ||
rules: | ||
- apiGroups: | ||
- redhatcop.redhat.io | ||
apiVersions: | ||
- v1alpha1 | ||
operations: | ||
- CREATE | ||
resources: | ||
- gcpauthengineroles | ||
sideEffects: None | ||
- admissionReviewVersions: | ||
- v1 | ||
|
@@ -179,6 +198,26 @@ webhooks: | |
resources: | ||
- gcpauthengineroles | ||
sideEffects: None | ||
- admissionReviewVersions: | ||
- v1 | ||
clientConfig: | ||
service: | ||
name: webhook-service | ||
namespace: system | ||
path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthengineconfig | ||
failurePolicy: Fail | ||
name: mgcpauthengineconfig.kb.io | ||
rules: | ||
- apiGroups: | ||
- redhatcop.redhat.io | ||
apiVersions: | ||
- v1alpha1 | ||
operations: | ||
- CREATE | ||
- UPDATE | ||
resources: | ||
- gcpauthengineconfigs | ||
sideEffects: None | ||
- admissionReviewVersions: | ||
- v1 | ||
clientConfig: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a problem here, again please generate this file with make config.