Fix: PSS label reset issue #821
Conversation
Signed-off-by: Varsha B <[email protected]>
openshift-ci
bot
added
kind/bug
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Thanks @varshab1210. I have left a suggestion in watch logic. PTAL. It would also be great to have some unit tests for this. Maybe a test to verify that labels are added to the namespace and correctly reconciled when modified. You can use below tests for reference.
Signed-off-by: Varsha B <[email protected]>
varshab1210
force-pushed
the
fix-enforce-version-label-reset
branch
from
afef117 to
b000341
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test v4.12-kuttl-parallel |
| Watches( | ||
| &corev1.Namespace{}, | ||
| &handler.EnqueueRequestForObject{}, | ||
| builder.WithPredicates(predicate.NewPredicateFuncs(func(obj client.Object) bool { | ||
| return obj.GetName() == "openshift-gitops" | ||
| })), | ||
| ). |
There was a problem hiding this comment.
Note to self: Use selectors at cache level to optimize memory consumption.
|
/lgtm |
Signed-off-by: Varsha B <[email protected]>
varshab1210
force-pushed
the
fix-enforce-version-label-reset
branch
from
341bec4 to
c269db4
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla, svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test v4.17-e2e |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-bot
bot
merged commit f652316
into
redhat-developer:master
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Previously, PSS labels in openshift-gitops ns did not get reconciled and reset upon modification to the values. This PR fixes the issue
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-5945
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: