bugfix:(helm#11391) helm lint infinite loop

when malformed template object Signed-off-by: wujunwei <[email protected]> (cherry picked from commit 316d3fb)
redhat-developer · Jun 14, 2023 · 5217482 · 5217482
1 parent 524a0e7
commit 5217482
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pkg/lint/rules/template.go b/pkg/lint/rules/template.go
@@ -141,10 +141,11 @@ func Templates(linter *support.Linter, values map[string]interface{}, namespace
 					break
 				}
 
-				// If YAML linting fails, we sill progress. So we don't capture the returned state
-				// on this linter run.
-				linter.RunLinterRule(support.ErrorSev, fpath, validateYamlContent(err))
-
+				// If YAML linting fails, it will always be fails next block. so we should return here.
+				// fix https://github.com/helm/helm/issues/11391
+				if !linter.RunLinterRule(support.ErrorSev, fpath, validateYamlContent(err)) {
+					return
+				}
 				if yamlStruct != nil {
 					// NOTE: set to warnings to allow users to support out-of-date kubernetes
 					// Refs https://github.com/helm/helm/issues/8596