Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sonarcloud issues #615

Merged
merged 13 commits into from
Dec 7, 2023

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

fix some sonar issues from sonar cloud

Was the change discussed in an issue?

How to test changes?

@sbouchet sbouchet requested a review from adietish November 10, 2023 15:43
@adietish
Copy link
Contributor

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 14, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 27, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish
Copy link
Contributor

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 30, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish
Copy link
Contributor

rebased

Signed-off-by: Stephane Bouchet <[email protected]>
adietish and others added 10 commits December 6, 2023 19:57
* chore: prepare 1.7.0

Signed-off-by: Stephane Bouchet <[email protected]>

* Update README.md

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

* Update README.md

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

* Update README.md

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

* Update README.md

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

* Update README.md

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

* Update Release Notes

Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>

---------

Signed-off-by: Stephane Bouchet <[email protected]>
Co-authored-by: Mohit Suman <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Copy link

sonarqubecloud bot commented Dec 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.0% 15.0% Coverage
5.6% 5.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

openshift-ci bot commented Dec 7, 2023

@sbouchet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-4.11 7f4a58c link true /test e2e-4.11

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbouchet
Copy link
Collaborator Author

sbouchet commented Dec 7, 2023

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Dec 7, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet
Copy link
Collaborator Author

sbouchet commented Dec 7, 2023

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Dec 7, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish
Copy link
Contributor

adietish commented Dec 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 7, 2023
@sbouchet sbouchet merged commit e1d81c7 into redhat-developer:main Dec 7, 2023
11 of 12 checks passed
@sbouchet sbouchet deleted the fix_sonar_issues branch December 7, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants