refactor: report telemetry when listing rels/charts #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
adietish
force-pushed
the
report_helm_telemetry
branch
from
38e7655 to
f589975
Compare
adietish
force-pushed
the
report_helm_telemetry
branch
from
f589975 to
918ae9f
Compare
adietish
changed the title
adietish
force-pushed
the
report_helm_telemetry
branch
2 times, most recently
from
e7e8301 to
fc96b0c
Compare
sbouchet
reviewed
Jan 8, 2024
src/main/java/org/jboss/tools/intellij/openshift/telemetry/TelemetryService.java
Outdated
Show resolved
Hide resolved
adietish
force-pushed
the
report_helm_telemetry
branch
from
fc96b0c to
f887e65
Compare
sbouchet
approved these changes
Jan 10, 2024
good point. I'll add another commit where I send async where it makes sense. |
|
@sbouchet replaced sync send(s) by async send(s) where I thought it makes sense. Please re-review. |
adietish
force-pushed
the
report_helm_telemetry
branch
from
321fa86 to
6605022
Compare
sbouchet
reviewed
Jan 11, 2024
src/main/java/org/jboss/tools/intellij/openshift/telemetry/TelemetrySender.java
Outdated
Show resolved
Hide resolved
sbouchet
reviewed
Jan 11, 2024
src/main/java/org/jboss/tools/intellij/openshift/telemetry/TelemetryService.java
Show resolved
Hide resolved
sbouchet
reviewed
Jan 11, 2024
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
adietish
force-pushed
the
report_helm_telemetry
branch
from
6605022 to
dddd979
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
report_helm_telemetry
branch
from
dddd979 to
91cd835
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
star import still present after fresh checkout in commit 91cd835 |
sbouchet
reviewed
Jan 11, 2024
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
adietish
force-pushed
the
report_helm_telemetry
branch
from
aaa15e2 to
a7ac138
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
report_helm_telemetry
branch
from
a7ac138 to
15ad00b
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit dada6a8
into
redhat-developer:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.