fix: corrected deprecated usage of ModuleLister.moduleAdded (#732) #740
Conversation
adietish
changed the title
adietish
force-pushed
the
issue-732
branch
2 times, most recently
from
8120951 to
f6109f5
Compare
|
|
ModuleListener#modulesAdded was added in IC-2022.3 and this PR thus requires us to bump the minimal version from (currently) |
I think we'll bump minimal version when 2024.1 will be out . |
|
I checked it and found out that I was wrong: the API required for this change only exists in |
|
@adietish this is still a warning on current 1.9.0 release. can you update this fix with latest main branch ? |
|
@sbouchet: we're currently still at |
|
|
@adietish what is the update on this PR ? |
|
@mohitsuman, @sbouchet: we're still at 2022.3: Do we want to bump so that we can include this PR? |
|
@adietish Are there any challenges in bumping ? |
|
And should we move this PR our of Draft state ? |
|
@mohitsuman @adietish : I propose to merge this PR after #889, bumping minimal version to 2023.1 . |
|
almost, there is still Integration UI test failures that @martinszuc is looking at |
|
@sbouchet rebased it. |
|
|
as expected, minimal version check (22.3) failed. let's wait for minimal version bump before merging this one. |
|
@sbouchet: intellij-kubernetes is now requiring |
…eveloper#732) Signed-off-by: Andre Dietisheim <[email protected]>
|
yes, now is a good time to do so. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-openshift "Integration UI Tests with Local Kind Cluster Context Report" |
|
@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report, ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Integration UI Tests with Local Kind Cluster Context Report" |
|
@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 2474d44
into
redhat-developer:main
(partially) fixes #732