fix: bump kubernetes-client to 7.0.0 (#921) #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
|
Some maven artifacts seem not available in the maven repo yet. The build works fine locally (with locally built kubernetes-client artifacts) though. ➜ intellij-openshift-connector git:(issue-921) ✗ ./gradlew clean buildPlugin
> Task :patchPluginXml
[gradle-intellij-plugin :patchPluginXml] Patching plugin.xml: value of 'version[1.0]' tag will be set to '1.10.2-SNAPSHOT'
> Task :verifyPluginConfiguration
[gradle-intellij-plugin :verifyPluginConfiguration] The following plugin configuration issues were found:
- The 'since-build' property is lower than the target IntelliJ Platform major version: 223 < 241.
See: https://jb.gg/intellij-platform-versions
> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :compileTestJava
Note: /Users/adietish/Documents/jboss-workspaces/intellij-openshift-connector/src/test/java/org/jboss/tools/intellij/openshift/actions/ActionTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :compileIntegrationTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 10s
16 actionable tasks: 16 executed |
|
kubernetes-client 7.0 was released: https://repo1.maven.org/maven2/io/fabric8/kubernetes-client/7.0.0/ |
adietish
changed the title
|
Quite some changes required to be able to do the bump:
|
adietish
force-pushed
the
issue-921
branch
2 times, most recently
from
da4dd97 to
778e652
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adietish
commented
Dec 13, 2024
| @@ -189,4 +190,9 @@ public void run() { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public @NotNull ActionUpdateThread getActionUpdateThread() { | |||
There was a problem hiding this comment.
This could/should have arguably been fixed in a separate issue. When the cluster isn't reachable, the EDT is stuck waiting and the platform throws an exception indicating this fix.
adietish
force-pushed
the
issue-921
branch
6 times, most recently
from
a4d8ae9 to
157ad6a
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
|
@sbouchet please review, thanks. |
|
With the change in intellij-common I need to update this PR to use the changed API |
adietish
force-pushed
the
issue-921
branch
2 times, most recently
from
4aeed1d to
eec86ae
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
|
@sbouchet bumped to use intellij-common 1.9.7 (Final). Please review. |
|
|
@adietish: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@adietish hile testing using a fresh instance ( means NO context ) and trying to connect to devsandbox, i get this error as soon i click on the login dialog: also, while looking a the logs, i get these one too: |
|
follow up: also, the dev on podman action isn't enabled ( it should be ) |
|
and last one ( maybe can be fixed in another issue ) : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on merging redhat-developer/intellij-common#247 and publishing intellij-common afterwards
fixes #921