Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable service tests #948

Merged
merged 12 commits into from
Dec 9, 2024

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Nov 18, 2024

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

see https://github.com/redhat-developer/service-binding-operator#deprecation-notice
and 404 while trying to install a compliant service (https://operatorhub.io/install/stable/cloud-native-postgresql.yaml)

How to test changes?

@openshift-ci openshift-ci bot requested a review from adietish November 18, 2024 16:18
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
@sbouchet sbouchet changed the title chore: update to latest IJ 2024.3 chore: disable service tests Dec 3, 2024
Signed-off-by: Stephane Bouchet <[email protected]>
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the nitpicks. I tend to think that comment(s) on why why disable service tests would help for later.

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2024
@sbouchet
Copy link
Collaborator Author

sbouchet commented Dec 3, 2024

seems all my @ignore comments are... ignored :D

Signed-off-by: Stephane Bouchet <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 4, 2024
Copy link

openshift-ci bot commented Dec 4, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
@adietish adietish added the lgtm label Dec 4, 2024
Signed-off-by: Stephane Bouchet <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 5, 2024
Copy link

openshift-ci bot commented Dec 5, 2024

New changes are detected. LGTM label has been removed.

@sbouchet
Copy link
Collaborator Author

sbouchet commented Dec 5, 2024

reverting IJ gradle plugin to 2.0.1 due to JetBrains/intellij-platform-gradle-plugin#1834

Copy link

sonarqubecloud bot commented Dec 5, 2024

@adietish adietish added the lgtm label Dec 6, 2024
@sbouchet
Copy link
Collaborator Author

sbouchet commented Dec 9, 2024

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Dec 9, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor

adietish commented Dec 9, 2024

/override "Integration UI Tests with Local Kind Cluster Context Report"

Copy link

openshift-ci bot commented Dec 9, 2024

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report

In response to this:

/override "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 20de3d6 into redhat-developer:main Dec 9, 2024
20 of 21 checks passed
@sbouchet sbouchet deleted the IJ-24.3 branch December 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants