-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable service tests #948
Conversation
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the nitpicks. I tend to think that comment(s) on why why disable service tests would help for later.
src/it/java/org/jboss/tools/intellij/openshift/utils/helm/Charts.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/helm/HelmCliTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliCatalogTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliCatalogTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliCatalogTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliServiceTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliServiceTest.java
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adietish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
seems all my @ignore comments are... ignored :D |
Signed-off-by: Stephane Bouchet <[email protected]>
New changes are detected. LGTM label has been removed. |
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
New changes are detected. LGTM label has been removed. |
reverting IJ gradle plugin to 2.0.1 due to JetBrains/intellij-platform-gradle-plugin#1834 |
Quality Gate passedIssues Measures |
/override ci/prow/e2e-openshift |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Integration UI Tests with Local Kind Cluster Context Report" |
@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
20de3d6
into
redhat-developer:main
What is the purpose of this change? What does it change?
Was the change discussed in an issue?
see https://github.com/redhat-developer/service-binding-operator#deprecation-notice
and 404 while trying to install a compliant service (https://operatorhub.io/install/stable/cloud-native-postgresql.yaml)
How to test changes?