Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduced span of ReadAction to avoid possible deadlock (#944) #962

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Jan 28, 2025

fixes #944

@adietish adietish self-assigned this Jan 28, 2025
@openshift-ci openshift-ci bot requested a review from sbouchet January 28, 2025 13:42
@adietish adietish marked this pull request as draft January 28, 2025 13:58
@adietish adietish marked this pull request as ready for review January 28, 2025 15:33
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jan 31, 2025

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jan 31, 2025

New changes are detected. LGTM label has been removed.

@adietish adietish added the lgtm label Jan 31, 2025
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Jan 31, 2025
@adietish
Copy link
Contributor Author

/override "ci/prow/e2e-openshift" "Aggregated Test Report" "Integration UI Tests with Local Kind Cluster Context Report"

Copy link

openshift-ci bot commented Jan 31, 2025

@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report, Integration UI Tests with Local Kind Cluster Context Report, ci/prow/e2e-openshift

In response to this:

/override "ci/prow/e2e-openshift" "Aggregated Test Report" "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-developer redhat-developer deleted a comment from openshift-ci bot Jan 31, 2025
@adietish
Copy link
Contributor Author

/override "Integration UI Tests with No Context Report"

Copy link

openshift-ci bot commented Jan 31, 2025

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with No Context Report

In response to this:

/override "Integration UI Tests with No Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fbac285 into redhat-developer:main Jan 31, 2025
20 checks passed
@adietish adietish deleted the issue-944 branch January 31, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants