-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For custom port mapping, handle case where ranged random port matches a custom local port #6727
For custom port mapping, handle case where ranged random port matches a custom local port #6727
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Signed-off-by: Parthvi Vala <[email protected]>
29f464d
to
126d81a
Compare
[FAILED] user-guides/quickstart/docs-mdx/go/go_odo_dev_output.mdx
Expected
<string>: (
"""
... // 9 identical lines
• Waiting for Kubernetes resources ...
âš Pod is Pending
- ✓ Pod is Running
✓ Syncing files into the container [1s]
✓ Building your application in container (command: build) [1s]
... // 9 identical lines
[Ctrl+c] - Exit and delete resources from the cluster
[p] - Manually apply local changes to the application on the cluster
+ ✓ Pod is Running
```
"""
)
/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Summarizing 1 Failure:
[FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
/go/odo_1/tests/e2escenarios/e2e_test.go:306
Ran 7 of 7 Specs in 170.404 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
+++++++++++
Summarizing 1 Failure:
[FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
C:/Users/Administrator.ANSIBLE-TEST-VS/3668/tests/helper/helper_cmd_wrapper.go:101
Ran 437 of 805 Specs in 1160.226 seconds
FAIL! -- 436 Passed | 1 Failed | 0 Pending | 368 Skipped /override windows-integration-test/Windows-test |
@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes part of #6479
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
odo init --devfile nodejs --starter nodejs-starter
odo dev --port-forward 20001:5858 --debug
Resulting port mapping: 3000 -> 20002, 5858 -> 20001